Issue 3008843002: Fixes for AST <-> binary serialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3008843002: Fixes for AST <-> binary serialization. (Closed)

Created:
3 years, 3 months ago by scheglov

Modified:
3 years, 3 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Kevin Millikin (Google), Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fixes for AST <-> binary serialization. I'm working on changes for KernelDriver to use Bazel-like model with tree shaking, and noticed these problems, because in this new model we serialize and deserialize kernels. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/80b16d6a88c2c30beb962fed36260a7ea90b2d33

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	pkg/kernel/lib/binary/ast_from_binary.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	pkg/kernel/lib/binary/ast_to_binary.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 3 months ago (2017-08-29 23:57:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
80b16d6a88c2c30beb962fed36260a7ea90b2d33 (presubmit successful).