Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 300883003: Add a dummy v8 target to BUILD.gn so we can depend on this from chrome (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Add a dummy v8 target to BUILD.gn so we can depend on this from chrome BUG=none R=dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-05-28 07:46:19 UTC) #1
dcarney
lgtm
6 years, 6 months ago (2014-05-28 08:00:23 UTC) #2
dcarney
lgtm lgtm
6 years, 6 months ago (2014-05-28 08:00:23 UTC) #3
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-05-28 11:49:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21566 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698