runtime/bin/vmservice/client/HACKING.txt - Issue 300883002: Add Proces owner of socket and fix printing of non-network sockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/HACKING.txt

Issue 300883002: Add Proces owner of socket and fix printing of non-network sockets (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/vmservice/client/HACKING.txt

diff --git a/runtime/bin/vmservice/client/HACKING.txt b/runtime/bin/vmservice/client/HACKING.txt

index d65c85f21d34476839aebc411245233719e2535d..6eee45edbc08c572e90de4b722477b439455ba7e 100644

--- a/runtime/bin/vmservice/client/HACKING.txt

+++ b/runtime/bin/vmservice/client/HACKING.txt

@@ -10,7 +10,7 @@ feature follow the steps:

1. Open runtime/bin/vmservice/client in the Dart Editor

2. Run pub upgrade

-3. Run dart --enable-vm-service --pause-isolates-on-exit script.dart

+3. Run dart --observe script.dart

4. Run index.html in Dartium

At this point you should see the initial Observatory UI and that

@@ -24,7 +24,7 @@ for review. Upload your change and get an LGTM.

At this point you should rebuild your VM and:

-7. Launch dart --enable-vm-service --pause-isolates-on-exit script.dart

+7. Launch dart --observe script.dart

In a non-Dart enabled browser navigate to localhost:8181 and ensure

that your feature works after being compiled to JavaScript.

« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | runtime/bin/vmservice/client/deployed/web/index.html » ('j') | no next file with comments »