Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Issue 3008813002: Add a missing import to compile_platform_test.dart. (Closed)

Created:
3 years, 3 months ago by devoncarew
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a missing import to compile_platform_test.dart. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/98370444fcc79d4314be73a6f342cbe26d0d4d89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/front_end/test/fasta/compile_platform_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
devoncarew
Add a missing import (for the `Future` class), and fix a typo.
3 years, 3 months ago (2017-08-29 20:05:02 UTC) #2
devoncarew
3 years, 3 months ago (2017-08-29 20:18:18 UTC) #4
Siggi Cherem (dart-lang)
lgtm
3 years, 3 months ago (2017-08-29 20:20:46 UTC) #5
devoncarew
Committed patchset #1 (id:1) manually as 98370444fcc79d4314be73a6f342cbe26d0d4d89 (presubmit successful).
3 years, 3 months ago (2017-08-29 20:22:07 UTC) #7
ahe
3 years, 3 months ago (2017-08-30 14:46:00 UTC) #8
Message was sent while issue was closed.
Thank you, Devon. I need to tweak how I run the analyzer.

Powered by Google App Engine
This is Rietveld 408576698