Use the entity model for dump_info.

pkg/compiler/lib/src/common_elements.dart

Index: pkg/compiler/lib/src/common_elements.dart
diff --git a/pkg/compiler/lib/src/common_elements.dart b/pkg/compiler/lib/src/common_elements.dart
index 86d62ea491d0f213d9421b18c281973a01eac4f2..336a1db52b941e2cbab8647fd7531d329c6746f6 100644
--- a/pkg/compiler/lib/src/common_elements.dart
+++ b/pkg/compiler/lib/src/common_elements.dart
@@ -14,6 +14,7 @@ import 'elements/types.dart';
 import 'js_backend/backend.dart' show JavaScriptBackend;
 import 'js_backend/constant_system_javascript.dart';
 import 'js_backend/native_data.dart' show NativeBasicData;
+import 'constants/expressions.dart' show ConstantExpression;
 import 'universe/call_structure.dart' show CallStructure;
 import 'universe/selector.dart' show Selector;
 import 'universe/call_structure.dart';
@@ -1252,13 +1253,21 @@ abstract class ElementEnvironment {
       ClassEntity cls, void f(ClassEntity declarer, MemberEntity member));
 
   /// Calls [f] for every constructor declared in [cls].
+  ///
+  /// Will ensure that the class and all constructors are resolved if
+  /// [ensureResolved] is `true`.
   void forEachConstructor(
-      ClassEntity cls, void f(ConstructorEntity constructor));
+      ClassEntity cls, void f(ConstructorEntity constructor),
+      {bool ensureResolved: true});

[Siggi Cherem (dart-lang), 2017/08/30 17:30:42]

since we don't really have "resolution" in the new pipeline, it seems odd to
expose the notion of "resolved" to the environment. I wonder if we should do
something different for this and `hasBeenResolved`.

For `hasBeenResolved` I have some ideas:

 - we could use `enqueuer.processedEntities.contains(member)` and
`enqueuer.processedClasses.contains(cls)`, but we need to make sure to use the
correct enqueuer: in the new world we have K and J elements, so the "resolution"
enqueuer will refer to the K elements, while the codegen refers to the J
elements. I believe you will be using the latter.

 - we could also use world.processedMembers (but may need to also add
processedClasses there)

For this function, I'm not sure what else to do, though.

Questions for Johnni: 
 - should we add processedClasses to world?
 - any preference between the alternatives above?
 - other ideas on what to do here?

I'm also OK landing with none or some of these changes, in which case let's just
add a "TODO(redemption)" to revisit these pieces later .

[Harry Terkelsen, 2017/08/30 21:28:50]

Done, except for classes I'm still asking if it was resolved (through
MirrorsData) since I need to get the static members of classes that may never
have been instantiated.

 
   /// Calls [f] for every constructor body in [cls].
   void forEachConstructorBody(
       ClassEntity cls, void f(ConstructorBodyEntity constructorBody));
 
+  /// Calls [f] for each nested closure in [member].
+  void forEachNestedClosure(
+      MemberEntity member, void f(FunctionEntity closure));
+
   /// Returns the superclass of [cls].
   ///
   /// If [skipUnnamedMixinApplications] is `true`, unnamed mixin applications
@@ -1338,6 +1347,9 @@ abstract class ElementEnvironment {
   /// Returns the type of the [local] function.
   FunctionType getLocalFunctionType(Local local);
 
+  /// Gets the constant value of [field], or `null` if [field] is non-const.
+  ConstantExpression getFieldConstant(FieldEntity field);
+
   /// Returns the 'unaliased' type of [type]. For typedefs this is the function
   /// type it is an alias of, for other types it is the type itself.
   ///
@@ -1364,4 +1376,10 @@ abstract class ElementEnvironment {
 
   /// Returns the function type that is an alias of a [typedef].
   FunctionType getFunctionTypeOfTypedef(TypedefEntity typedef);
+
+  /// Returns `true` if [entity] has been resolved.
+  bool hasBeenResolved(Entity entity);
+
+  /// Returns `true` if [cls] has been resolved.
+  bool hasClassBeenResolved(ClassEntity cls);
 }