Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 3008783002: Run the parser recovery tests under fasta (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : use 'with' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+701 lines, -3 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 2 chunks +695 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
These are currently all failing because the tests expect an error, and that isn't supported ...
3 years, 3 months ago (2017-08-29 18:25:05 UTC) #2
danrubel
LGTM
3 years, 3 months ago (2017-08-29 18:26:13 UTC) #3
Brian Wilkerson
3 years, 3 months ago (2017-08-29 18:30:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
75ee4aa54669a492baf549ee9acc45107c260822 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698