Store actual Reference(s) for additional exports.

pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart

Index: pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart b/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
index 48bcb98b9f1cf622846ee2cc37ff69860621e3a9..6424bebc58315fba08751eb03cb297d066548037 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
@@ -4,20 +4,9 @@
 
 library fasta.dill_library_builder;
 
-import 'dart:convert' show JSON;
-
 import 'package:kernel/ast.dart'
-    show
-        Class,
-        Field,
-        Library,
-        ListLiteral,
-        Member,
-        StaticGet,
-        StringLiteral,
-        Typedef;
-
-import '../fasta_codes.dart' show templateUnspecified;
+    show Class, Field, Library, ListLiteral, Member, StaticGet, Typedef;
+import 'package:kernel/ast.dart';

[ahe, 2017/08/30 14:24:52]

Remove the second import of kernel/ast.dart.

[scheglov, 2017/08/30 16:56:49]

Done.

 
 import '../problems.dart' show unimplemented;
 
@@ -47,18 +36,9 @@ class DillLibraryBuilder extends LibraryBuilder<KernelTypeBuilder, Library> {
 
   Library library;
 
-  /// Exports in addition to the members declared in this library.
-  ///
-  /// Each entry in the list is either two or three elements long.
-  ///
-  /// The first element is the library URI, if it is null, this is an ambiguous
-  /// export and the list has three elements. Otherwise the list has two
-  /// elements.
-  ///
-  /// The second element is the name of the exported element.
-  ///
-  /// The third element (if present) is an error message.
-  List<List<String>> additionalExports;
+  /// References to nodes exported by the `export` directives, don't conflict

[ahe, 2017/08/30 14:24:52]

Consider this:

/// References to nodes exported by `export` declarations that:
/// - aren't ambiguous, or
/// - aren't hidden by local declarations.

[scheglov, 2017/08/30 16:56:49]

Done.

+  /// with each other, and not are hidden by local declarations.
+  List<Reference> additionalExports;
 
   DillLibraryBuilder(this.uri, this.loader)
       : super(uri, new Scope.top(), new Scope.top());
@@ -88,13 +68,7 @@ class DillLibraryBuilder extends LibraryBuilder<KernelTypeBuilder, Library> {
 
   void addMember(Member member) {
     String name = member.name.name;
-    if (name == "_exports#") {
-      Field field = member;
-      StringLiteral string = field.initializer;
-      additionalExports = JSON.decode(string.value);
-    } else {
-      addBuilder(name, new DillMemberBuilder(member, this), member.fileOffset);
-    }
+    addBuilder(name, new DillMemberBuilder(member, this), member.fileOffset);
   }
 
   Builder addBuilder(String name, Builder builder, int charOffset) {
@@ -145,19 +119,27 @@ class DillLibraryBuilder extends LibraryBuilder<KernelTypeBuilder, Library> {
   }
 
   void finalizeExports() {
-    if (additionalExports != null) {
-      for (List<String> additionalExport in additionalExports) {
-        String uriString = additionalExport[0];
-        String name = additionalExport[1];
-        Builder builder;
-        if (uriString == null) {
-          builder = new KernelInvalidTypeBuilder(name, -1, null,
-              templateUnspecified.withArguments(additionalExport[2]));
-        } else {
-          DillLibraryBuilder library = loader.read(uri.resolve(uriString), -1);
-          builder = library?.exportScopeBuilder[name] ??
-              new KernelInvalidTypeBuilder(name, -1, null);
-        }
+    for (var reference in library.additionalExports) {
+      var node = reference.node;
+      Uri libraryUri;
+      String name;
+      if (node is Class) {
+        libraryUri = node.enclosingLibrary.importUri;
+        name = node.name;
+      } else if (node is Member) {
+        libraryUri = node.enclosingLibrary.importUri;
+        name = node.name.name;
+      } else if (node is Typedef) {
+        libraryUri = node.enclosingLibrary.importUri;
+        name = node.name;
+      } else {
+        unimplemented('${node.runtimeType}', -1, uri);
+      }
+      var library = loader.read(libraryUri, -1);
+      Builder builder = library.exportScopeBuilder[name];

[ahe, 2017/08/30 14:24:52]

assert(node == builder.target);

[scheglov, 2017/08/30 16:56:50]

Done.

+      if (builder.isSetter) {
+        exportScopeBuilder.addSetter(name, builder);
+      } else {
         exportScopeBuilder.addMember(name, builder);
       }
     }