Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 3008753002: Avoid Element-only assertions in generateParameterStubs (Closed)

Created:
3 years, 3 months ago by sra1
Modified:
3 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : status #

Patch Set 3 : status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -124 lines) Patch
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 chunk +14 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 2 chunks +0 lines, -6 lines 0 comments Download
M tests/corelib/corelib.status View 3 chunks +1 line, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 13 chunks +24 lines, -99 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 1 2 5 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
Committed patchset #3 (id:40001) manually as 043708d48c77767944892adeb2f95bc8ec0dc49f (presubmit successful).
3 years, 3 months ago (2017-08-29 04:23:35 UTC) #2
sra1
On 2017/08/29 04:23:35, sra1 wrote: > Committed patchset #3 (id:40001) manually as > 043708d48c77767944892adeb2f95bc8ec0dc49f (presubmit ...
3 years, 3 months ago (2017-08-29 04:25:05 UTC) #3
Johnni Winther
3 years, 3 months ago (2017-08-29 08:06:22 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698