Issue 300873007: Revert of add colortable support to imagegenerator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300873007: Revert of add colortable support to imagegenerator (Closed)

Created:
6 years, 6 months ago by reed1

Modified:
6 years, 6 months ago

Reviewers:
hal.canary, scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/) Reason for revert: failing tests Original issue's description: > add colortable support to imagegenerator > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14916 TBR=halcanary@google.com,scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14917

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -176 lines)			Patch
M	gyp/images.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkImageGenerator.h	View	5 chunks	+5 lines, -32 lines	0 comments	Download
M	src/images/SkDecodingImageGenerator.cpp	View	7 chunks	+42 lines, -35 lines	0 comments	Download
D	src/images/SkImageGenerator.cpp	View	1 chunk	+0 lines, -79 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	1 chunk	+2 lines, -17 lines	0 comments	Download
M	tests/CachedDecodingPixelRefTest.cpp	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	tests/DrawBitmapRectTest.cpp	View	1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/300873007/1

6 years, 6 months ago (2014-05-28 16:15:57 UTC) #2

Message was sent while issue was closed.

Change committed as 14917