tools/testrunner/local/execution.py - Issue 300873006: Use non-copying sorting in test harness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testrunner/local/execution.py

Issue 300873006: Use non-copying sorting in test harness. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testrunner/local/execution.py

diff --git a/tools/testrunner/local/execution.py b/tools/testrunner/local/execution.py

index 80a5989be2f255a672b872adca74b284ad2ef49c..13e3439d6c74364a0489807e1f9729f2293f312a 100644

--- a/tools/testrunner/local/execution.py

+++ b/tools/testrunner/local/execution.py

@@ -95,7 +95,7 @@ class Runner(object):

queue = []

queued_exception = None

if not self.context.no_sorting:

- self.tests = sorted(self.tests, key=lambda t: t.duration, reverse=True)

+ self.tests.sort(key=lambda t: t.duration, reverse=True)

Michael Achenbach 2014/05/28 12:03:21 Maybe move to line 68 right after the duration ini

Michael Starzinger 2014/05/28 12:13:30 Done.

for test in self.tests:

assert test.id >= 0

test_map[test.id] = test

« no previous file with comments | « no previous file | no next file » | no next file with comments »