Use non-copying sorting in test harness.

Use non-copying sorting in test harness.

R=machenbach@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21569

[Michael Achenbach, 2014-05-28 12:03:21]

lgtm with a comment:

https://codereview.chromium.org/300873006/diff/1/tools/testrunner/local/execu...
File tools/testrunner/local/execution.py (right):

https://codereview.chromium.org/300873006/diff/1/tools/testrunner/local/execu...
tools/testrunner/local/execution.py:98: self.tests.sort(key=lambda t:
t.duration, reverse=True)
Maybe move to line 68 right after the duration initialization and also skip that
initialization dependent on the flag.

[Michael Starzinger, 2014-05-28 12:13:30]

https://codereview.chromium.org/300873006/diff/1/tools/testrunner/local/execu...
File tools/testrunner/local/execution.py (right):

https://codereview.chromium.org/300873006/diff/1/tools/testrunner/local/execu...
tools/testrunner/local/execution.py:98: self.tests.sort(key=lambda t:
t.duration, reverse=True)
On 2014/05/28 12:03:21, Michael Achenbach wrote:
> Maybe move to line 68 right after the duration initialization and also skip
that
> initialization dependent on the flag.

Done.

[Michael Achenbach, 2014-05-28 12:37:28]

https://codereview.chromium.org/300873006/diff/20001/tools/testrunner/local/e...
File tools/testrunner/local/execution.py (right):

https://codereview.chromium.org/300873006/diff/20001/tools/testrunner/local/e...
tools/testrunner/local/execution.py:67: for t in self.tests:
I also meant that "if not self.context.no_sorting:" could include lines 67 and
68. No need to fetch perf data and initialize it if we don't sort based on it.

[Michael Starzinger, 2014-05-28 12:51:07]

Thanks for the review. Addressed comments. Landing.

https://codereview.chromium.org/300873006/diff/20001/tools/testrunner/local/e...
File tools/testrunner/local/execution.py (right):

https://codereview.chromium.org/300873006/diff/20001/tools/testrunner/local/e...
tools/testrunner/local/execution.py:67: for t in self.tests:
On 2014/05/28 12:37:28, Michael Achenbach wrote:
> I also meant that "if not self.context.no_sorting:" could include lines 67 and
> 68. No need to fetch perf data and initialize it if we don't sort based on it.

Done.

[Michael Achenbach, 2014-05-28 13:01:23]

lgtm!

[Michael Starzinger, 2014-05-28 13:01:54]

Committed patchset #3 manually as r21569 (presubmit successful).