Migrate block 163 to Dart 2.0.

Migrate block 163 to Dart 2.0.

Interesting tests requiring status file or other changes:

type_variable_promotion_test
type_variable_scope_test
type_variable_static_context_negative_test - changed from negative to compile-time error
unresolved_top_level_method_negative_test - changed from negative to compile-time error
unary_plus_negative_test
unhandled_exception_negative_test
unbound_getter_test
unresolved_in_factory_negative_test -
unresolved_top_level_var_negative_test - changed from negative to compile-time error
unresolved_top_level_method_negative_test - changed from negative to compile-time error
vm/async_await_catch_stacktrace_test

BUG=
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/fe7c2acd4e48b3c2777dfb806f0e446ccebfbfa0

[jcollins, 2017-08-28 19:01:45]

jcollins@google.com changed reviewers:
+ lrn@google.com, rnystrom@google.com

[jcollins, 2017-08-28 19:01:47]

This test block had a fair number of situations that never can happen in Dart
2.0 and so were converted to compile-time error expectations.  Changes were
straightforward though there were a number of them.

[jcollins, 2017-08-28 19:02:28]

Description was changed from

==========
Migrate block 163 to Dart 2.0.

Interesting tests requiring status file or other changes:

type_variable_promotion_test
type_variable_scope_test
type_variable_static_context_negative_test - changed from negative to
compile-time error
unresolved_top_level_method_negative_test
unary_plus_negative_test
unhandled_exception_negative_test
unbound_getter_test
unresolved_in_factory_negative_test -
unresolved_top_level_var_negative_test - changed from negative to compile-time
error
unresolved_top_level_method_negative_test - changed from negative to
compile-time error
vm/async_await_catch_stacktrace_test

BUG=
==========

to

==========
Migrate block 163 to Dart 2.0.

Interesting tests requiring status file or other changes:

type_variable_promotion_test
type_variable_scope_test
type_variable_static_context_negative_test - changed from negative to
compile-time error
unresolved_top_level_method_negative_test - changed from negative to
compile-time error
unary_plus_negative_test
unhandled_exception_negative_test
unbound_getter_test
unresolved_in_factory_negative_test -
unresolved_top_level_var_negative_test - changed from negative to compile-time
error
unresolved_top_level_method_negative_test - changed from negative to
compile-time error
vm/async_await_catch_stacktrace_test

BUG=
==========

[Lasse Reichstein Nielsen, 2017-08-29 08:49:45]

lgtm

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
File tests/language_2/type_variable_nested_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_nested_test.dart:21: var a = new B();
This makes a._copy be a List<A<dynamic>> (right?)

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_nested_test.dart:24: Expect.isTrue(a._copy is
List<A<int>>);
In Dart 2, List<A<dynamic>> is! List<A<int>>, so this should be false.

(Caveat: I might have some wrong ideas about strong mode :)

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
File tests/language_2/type_variable_promotion_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_promotion_test.dart:14: var list = [x];
What is this testing? The name suggests promotion, but I don't think there there
is any promotion going on.
There is no type promotion from T to B because B is not known to be more
specific than T (because T is a type variable, it is not its bound), so the type
of "x" is still T, and the resulting list is a List<T> (with T == B). No type
promotion and the result is correct, so what is the test testing?

Or am I missing how type promotion works?

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_promotion_test.dart:34:
Expect.listEquals(foo.bar(b), [b]);
listEquals only checks length and content, so it's not related to type promotion
at all. Not sure what that line tests (except that `x is B` correctly detects
`b` as implementing `B`.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
File tests/language_2/type_variable_scope2_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_scope2_test.dart:7: // Test that malformed type
arguments are treated as dynamic.
Seems they are treated as an error, not dynamic. Update text?

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unbound_ge...
File tests/language_2/unbound_getter_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unbound_ge...
tests/language_2/unbound_getter_test.dart:13: main() {
Do `new A().foo()` here just to be sure.

I'm not certain whether tree-shaking is still allowed in Dart 2, and if there is
no reference to A or A.foo, the compile-time error might not be recognized.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unhandled_...
File tests/language_2/unhandled_exception_negative_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unhandled_...
tests/language_2/unhandled_exception_negative_test.dart:7: const
MyException([String message = ""]) : message_ = message;
Or make it non-optional, the parameter doesn't seem to be used as optional at
all.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unused_ove...
File tests/language_2/unused_overridden_async_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unused_ove...
tests/language_2/unused_overridden_async_test.dart:13: @override
Remove @override. We don't use that in the platform libraries, so we shouldn't
be using it in the tests either.

[jcollins, 2017-08-29 17:39:11]

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
File tests/language_2/type_variable_nested_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_nested_test.dart:21: var a = new B();
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> This makes a._copy be a List<A<dynamic>> (right?)

That'd be my understanding, but I'm no expert..

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_nested_test.dart:24: Expect.isTrue(a._copy is
List<A<int>>);
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> In Dart 2, List<A<dynamic>> is! List<A<int>>, so this should be false.
> 
> (Caveat: I might have some wrong ideas about strong mode :)

Your ideas so far seem fine :-)

Fixing this enables the test to pass in DDC though breaks it everywhere else,
which seems to be the pattern in this kind of thing.

Extracted the line into a multitest to not lose coverage on the VM and updated
status files.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
File tests/language_2/type_variable_promotion_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_promotion_test.dart:14: var list = [x];
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> What is this testing? The name suggests promotion, but I don't think there
there
> is any promotion going on.
> There is no type promotion from T to B because B is not known to be more
> specific than T (because T is a type variable, it is not its bound), so the
type
> of "x" is still T, and the resulting list is a List<T> (with T == B). No type
> promotion and the result is correct, so what is the test testing?
> 
> Or am I missing how type promotion works?

Nope, you're not missing anything.  With fresher eyes I realize I misinterpreted
what was going on here and made a change that negated the purpose of the test. 
I think the original test was probably correct, it's just that nothing else but
DDC seems to do type promotion in this way.

Fixed, and status files updated.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_promotion_test.dart:34:
Expect.listEquals(foo.bar(b), [b]);
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> listEquals only checks length and content, so it's not related to type
promotion
> at all. Not sure what that line tests (except that `x is B` correctly detects
> `b` as implementing `B`.

Yes.  I think it's probably written this way to be sure that the type parameter
T for bar's 'x' gets correctly promoted to B within bar(), thus forcing the call
inside the if block.   But I could be wrong.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
File tests/language_2/type_variable_scope2_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_scope2_test.dart:7: // Test that malformed type
arguments are treated as dynamic.
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> Seems they are treated as an error, not dynamic. Update text?

Done.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unbound_ge...
File tests/language_2/unbound_getter_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unbound_ge...
tests/language_2/unbound_getter_test.dart:13: main() {
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> Do `new A().foo()` here just to be sure.
> 
> I'm not certain whether tree-shaking is still allowed in Dart 2, and if there
is
> no reference to A or A.foo, the compile-time error might not be recognized.
> 

Done.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unhandled_...
File tests/language_2/unhandled_exception_negative_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unhandled_...
tests/language_2/unhandled_exception_negative_test.dart:7: const
MyException([String message = ""]) : message_ = message;
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> Or make it non-optional, the parameter doesn't seem to be used as optional at
> all.

Done, and removing default.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unused_ove...
File tests/language_2/unused_overridden_async_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/unused_ove...
tests/language_2/unused_overridden_async_test.dart:13: @override
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> Remove @override. We don't use that in the platform libraries, so we shouldn't
> be using it in the tests either.

Done.

[Bob Nystrom, 2017-08-29 22:57:26]

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
File tests/language_2/type_variable_nested_test.dart (right):

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_nested_test.dart:21: var a = new B();
On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> This makes a._copy be a List<A<dynamic>> (right?)

That's correct.

https://codereview.chromium.org/3008723002/diff/1/tests/language_2/type_varia...
tests/language_2/type_variable_nested_test.dart:24: Expect.isTrue(a._copy is
List<A<int>>);
On 2017/08/29 17:39:10, jcollins wrote:
> On 2017/08/29 08:49:44, Lasse Reichstein Nielsen wrote:
> > In Dart 2, List<A<dynamic>> is! List<A<int>>, so this should be false.
> > 
> > (Caveat: I might have some wrong ideas about strong mode :)
> 
> Your ideas so far seem fine :-)
> 
> Fixing this enables the test to pass in DDC though breaks it everywhere else,
> which seems to be the pattern in this kind of thing.

Breaking everywhere else makes sense since they don't implement strong mode yet.

[jcollins, 2017-08-30 15:05:20]

Description was changed from

==========
Migrate block 163 to Dart 2.0.

Interesting tests requiring status file or other changes:

type_variable_promotion_test
type_variable_scope_test
type_variable_static_context_negative_test - changed from negative to
compile-time error
unresolved_top_level_method_negative_test - changed from negative to
compile-time error
unary_plus_negative_test
unhandled_exception_negative_test
unbound_getter_test
unresolved_in_factory_negative_test -
unresolved_top_level_var_negative_test - changed from negative to compile-time
error
unresolved_top_level_method_negative_test - changed from negative to
compile-time error
vm/async_await_catch_stacktrace_test

BUG=
==========

to

==========
Migrate block 163 to Dart 2.0.

Interesting tests requiring status file or other changes:

type_variable_promotion_test
type_variable_scope_test
type_variable_static_context_negative_test - changed from negative to
compile-time error
unresolved_top_level_method_negative_test - changed from negative to
compile-time error
unary_plus_negative_test
unhandled_exception_negative_test
unbound_getter_test
unresolved_in_factory_negative_test -
unresolved_top_level_var_negative_test - changed from negative to compile-time
error
unresolved_top_level_method_negative_test - changed from negative to
compile-time error
vm/async_await_catch_stacktrace_test

BUG=
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fe7c2acd4e48b3c2777dfb806f0e446ccebfbfa0
==========

[jcollins, 2017-08-30 15:05:21]

Committed patchset #2 (id:20001) manually as
fe7c2acd4e48b3c2777dfb806f0e446ccebfbfa0.