Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 3008673002: Update status file for precompiled (Closed)

Created:
3 years, 3 months ago by jensj
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update status file for precompiled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/language_2/language_2_precompiled.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jensj
3 years, 3 months ago (2017-08-28 06:10:42 UTC) #2
jensj
tbr
3 years, 3 months ago (2017-08-28 06:11:04 UTC) #3
jensj
Committed patchset #1 (id:1) manually as b54bb0cf2762d0652dd127e80413b78fa8772d42 (presubmit successful).
3 years, 3 months ago (2017-08-28 06:11:20 UTC) #5
Vyacheslav Egorov (Google)
lgtm
3 years, 3 months ago (2017-08-28 06:12:22 UTC) #6
jensj
So that didn't work... It passes on "precomp-linux-debug-x64" but crashes with "Class with illegal cid" ...
3 years, 3 months ago (2017-08-28 06:59:52 UTC) #7
jensj
3 years, 3 months ago (2017-08-28 07:00:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5624fef4fdf3101f8267d4d56033cb73a192aec8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698