chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h - Issue 300863002: mac: History swiping doesn't work right with iframes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h

Issue 300863002: mac: History swiping doesn't work right with iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm » ('j') | chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_RENDERER_HOST_CHROME_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE _H_	5 #ifndef CHROME_BROWSER_RENDERER_HOST_CHROME_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE _H_

6 #define CHROME_BROWSER_RENDERER_HOST_CHROME_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE _H_	6 #define CHROME_BROWSER_RENDERER_HOST_CHROME_RENDER_WIDGET_HOST_VIEW_MAC_DELEGATE _H_

7	7

8 #import <Cocoa/Cocoa.h>	8 #import <Cocoa/Cocoa.h>

9	9

10 #include "base/mac/scoped_nsobject.h"	10 #include "base/mac/scoped_nsobject.h"

(...skipping 21 matching lines...) Expand all Loading...
32 BOOL spellcheckChecked_;	32 BOOL spellcheckChecked_;

33	33

34 // Responsible for 2-finger swipes history navigation.	34 // Responsible for 2-finger swipes history navigation.

35 base::scoped_nsobject<HistorySwiper> historySwiper_;	35 base::scoped_nsobject<HistorySwiper> historySwiper_;

36 }	36 }

37	37

38 - (id)initWithRenderWidgetHost:(content::RenderWidgetHost*)renderWidgetHost;	38 - (id)initWithRenderWidgetHost:(content::RenderWidgetHost*)renderWidgetHost;

39	39

40 - (void)viewGone:(NSView*)view;	40 - (void)viewGone:(NSView*)view;

41 - (BOOL)handleEvent:(NSEvent*)event;	41 - (BOOL)handleEvent:(NSEvent*)event;

42 - (void)gotUnhandledWheelEvent;

43 - (void)scrollOffsetPinnedToLeft:(BOOL)left toRight:(BOOL)right;	42 - (void)scrollOffsetPinnedToLeft:(BOOL)left toRight:(BOOL)right;

44 - (void)setHasHorizontalScrollbar:(BOOL)hasHorizontalScrollbar;	43 - (void)setHasHorizontalScrollbar:(BOOL)hasHorizontalScrollbar;

45 - (BOOL)validateUserInterfaceItem:(id<NSValidatedUserInterfaceItem>)item	44 - (BOOL)validateUserInterfaceItem:(id<NSValidatedUserInterfaceItem>)item

46 isValidItem:(BOOL*)valid;	45 isValidItem:(BOOL*)valid;

47

48 @end	46 @end

49	47

50 #endif // CHROME_BROWSER_RENDERER_HOST_CHROME_RENDER_WIDGET_HOST_VIEW_MAC_DELEG ATE_H_	48 #endif // CHROME_BROWSER_RENDERER_HOST_CHROME_RENDER_WIDGET_HOST_VIEW_MAC_DELEG ATE_H_

OLD	NEW