Issue 3008603002: Revert "Revert "Reduce use of getClosureInfoForMember and cleanup closure_test""

Issue 3008603002: Revert "Revert "Reduce use of getClosureInfoForMember and cleanup closure_test"" (Closed)

Created:
3 years, 3 months ago by Emily Fortuna

Modified:
3 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Revert "Reduce use of getClosureInfoForMember and cleanup closure_test"" This reverts commit e94ff86b2bd237a5e007f11d9ec4c5272103e945. Reapply Johnni's change with the status file updates. BUG= Committed: https://github.com/dart-lang/sdk/commit/fba36729ec242af7e621416c3c3a4e2cb36e04a3

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -69 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	2 chunks	+2 lines, -15 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/js_model/closure.dart	View	2 chunks	+4 lines, -12 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/closure/closure_test.dart	View	6 chunks	+19 lines, -18 lines	0 comments	Download
M	tests/compiler/dart2js/closure/data/captured_variable.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/equivalence/id_equivalence_helper.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/language_2/language_2_dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (2 generated)

Emily Fortuna

ahem. Sorry about that. I was looking at the diff backwards thinking it added failures ...

3 years, 3 months ago (2017-08-26 01:14:08 UTC) #2

Emily Fortuna

3 years, 3 months ago (2017-08-26 01:14:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fba36729ec242af7e621416c3c3a4e2cb36e04a3 (presubmit successful).