Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 3008583002: Fix status for generic_methods_local_variable_declaration_test. (Closed)

Created:
3 years, 3 months ago by Bob Nystrom
Modified:
3 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix status for generic_methods_local_variable_declaration_test. I hope. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/d9d908170aea0e1652748b99b300d0db7120d96f

Patch Set 1 #

Patch Set 2 : Handle crashing in kernel. #

Patch Set 3 : Passin' not crashin'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tests/language_2/language_2_dart2js.status View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 3 months ago (2017-08-25 23:38:08 UTC) #2
Emily Fortuna
LGTM!!! 🎉🎉🎉🎉
3 years, 3 months ago (2017-08-25 23:48:25 UTC) #3
Bob Nystrom
3 years, 3 months ago (2017-08-25 23:49:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d9d908170aea0e1652748b99b300d0db7120d96f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698