tools/patch_sdk.dart - Issue 3008563002: Removed Dartium SDK libs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/patch_sdk.dart

Issue 3008563002: Removed Dartium SDK libs (Closed)

Patch Set: Needed few more definitions in dartium include (now removed). Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/patch_sdk.dart

diff --git a/tools/patch_sdk.dart b/tools/patch_sdk.dart

index 0f7b10aed65317312621a5bbded00daff2a50a08..614fe2c38a9e0ed2675888bc659be95e1174c6c4 100644

--- a/tools/patch_sdk.dart

+++ b/tools/patch_sdk.dart

@@ -43,7 +43,7 @@ final deps = new Set<Uri>();

File getInputFile(String path, {canBeMissing: false}) {

final file = new File(path);

if (!file.existsSync()) {

- if (!canBeMissing) throw "patch_sdk.dart expects all inputs to exist";

+ if (!canBeMissing) throw "patch_sdk.dart expects all inputs to exist $path";

Alan Knight 2017/08/30 22:54:49 The error could be a little clearer, e.g. to exist

terry 2017/08/31 14:29:30 Done.

return null;

}

deps.add(Uri.base.resolveUri(file.uri));