Source/core/rendering/line/BreakingContext.cpp - Issue 300853007: Empty inline elements always get a line box.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/line/BreakingContext.cpp

Issue 300853007: Empty inline elements always get a line box. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/line/BreakingContext.cpp

diff --git a/Source/core/rendering/line/BreakingContext.cpp b/Source/core/rendering/line/BreakingContext.cpp

index 4f24e2b9b31c3b4faa1ae0f4d9291cb38b38134c..513b2c3beaa96ea8faba3b616792b6bc8e257fc3 100644

--- a/Source/core/rendering/line/BreakingContext.cpp

+++ b/Source/core/rendering/line/BreakingContext.cpp

@@ -48,7 +48,7 @@ InlineIterator BreakingContext::handleEndOfLine()

// Sanity check our midpoints.

m_lineMidpointState.checkMidpoints(m_lineBreak);

- m_trailingObjects.updateMidpointsForTrailingBoxes(m_lineMidpointState, m_lineBreak, TrailingObjects::CollapseFirstSpace);

+ m_trailingObjects.updateMidpointsForTrailingObjects(m_lineMidpointState, m_lineBreak, TrailingObjects::CollapseFirstSpace);

// We might have made lineBreak an iterator that points past the end

// of the object. Do this adjustment to make it point to the start