Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 3008503002: Migrate many_generic_instanceof_test to language_2. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
bkonyi
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate many_generic_instanceof_test to language_2. It relies on a utility library that was already moved over, so this gets it working again. Committed: https://github.com/dart-lang/sdk/commit/af1d9354b076c4ea79b20031c19798a38af31e76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -44 lines) Patch
M tests/language/language_dart2js.status View 2 chunks +0 lines, -2 lines 0 comments Download
D tests/language/many_generic_instanceof_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 3 chunks +3 lines, -0 lines 0 comments Download
M tests/language_2/language_2_precompiled.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language_2/language_2_vm.status View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language_2/many_generic_instanceof_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 chunk +0 lines, -1 line 0 comments Download
D tests/language_strong/many_generic_instanceof_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 4 months ago (2017-08-24 19:18:56 UTC) #2
Bob Nystrom
TBR.
3 years, 4 months ago (2017-08-24 19:22:04 UTC) #3
Bob Nystrom
3 years, 4 months ago (2017-08-24 19:23:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af1d9354b076c4ea79b20031c19798a38af31e76.

Powered by Google App Engine
This is Rietveld 408576698