Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 3008493002: Add documentation for the new notification support (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/analyzer_plugin/doc/tutorial/navigation.md View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-24 18:10:49 UTC) #2
scheglov
LGTM https://codereview.chromium.org/3008493002/diff/1/pkg/analyzer_plugin/doc/tutorial/navigation.md File pkg/analyzer_plugin/doc/tutorial/navigation.md (right): https://codereview.chromium.org/3008493002/diff/1/pkg/analyzer_plugin/doc/tutorial/navigation.md#newcode18 pkg/analyzer_plugin/doc/tutorial/navigation.md:18: When a notification needs to be sent, the ...
3 years, 4 months ago (2017-08-24 18:19:21 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-24 18:26:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c8fbfad81e897582ce7e930440577f5f803d211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698