Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3008463002: Store the covariant keyword flag for parameters and fields into Kernel and resynthesize in analyzer. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store the covariant keyword flag for parameters and fields into Kernel and resynthesize in analyzer. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/827075befb775979d9ea439c0597c20214da174f

Patch Set 1 #

Patch Set 2 : Update Field in binary. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -27 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 3 chunks +0 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/modifier_builder.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/front_end/testcases/runtime_checks/call_through_this.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/runtime_checks/call_through_this.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/runtime_checks/covariant_keyword.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/runtime_checks/covariant_keyword.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/runtime_checks/dynamic_invocation.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/runtime_checks/dynamic_invocation.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/binary.md View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 7 chunks +22 lines, -2 lines 0 comments Download
M pkg/kernel/lib/clone.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 4 months ago (2017-08-24 03:39:13 UTC) #1
Paul Berry
lgtm
3 years, 4 months ago (2017-08-24 04:58:03 UTC) #2
Kevin Millikin (Google)
Also LGTM.
3 years, 4 months ago (2017-08-24 12:08:45 UTC) #3
scheglov
3 years, 4 months ago (2017-08-24 14:17:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
827075befb775979d9ea439c0597c20214da174f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698