Issue 3008453002: Build / resynthesize final fields as ConstFieldElementImpl only if the enclosing class has a consta…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3008453002: Build / resynthesize final fields as ConstFieldElementImpl only if the enclosing class has a consta… (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Build / resynthesize final fields as ConstFieldElementImpl only if the enclosing class has a constant constructor. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3d7d829e450c0517e9497c13e28329d36e9e54d8

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -53 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/builder.dart	View	3 chunks	+19 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/dart/element/element.dart	View	4 chunks	+27 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_common.dart	View	6 chunks	+10 lines, -18 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart	View	2 chunks	+0 lines, -25 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 4 months ago (2017-08-24 17:01:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3d7d829e450c0517e9497c13e28329d36e9e54d8 (presubmit successful).