Enhance NavigationMixin to handle notifications

Enhance NavigationMixin to handle notifications

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e8010e4a44ec5acb0ae4f432a90d54525680559c

[Brian Wilkerson, 2017-08-23 21:32:02]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-08-23 21:36:21]

LGTM

https://codereview.chromium.org/3008443002/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/navigation_mixin.dart (right):

https://codereview.chromium.org/3008443002/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/navigation_mixin.dart:81: * server. If a [result]
is provided then it is expected to be the result of
What [result]?

[Brian Wilkerson, 2017-08-24 14:27:59]

ptal. I realized that I'd forgotten to add a test for the new API.

https://codereview.chromium.org/3008443002/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/navigation_mixin.dart (right):

https://codereview.chromium.org/3008443002/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/navigation_mixin.dart:81: * server. If a [result]
is provided then it is expected to be the result of
Removed.

[scheglov, 2017-08-24 14:32:19]

LGTM

[Brian Wilkerson, 2017-08-24 14:44:51]

Description was changed from

==========
Enhance NavigationMixin to handle notifications
==========

to

==========
Enhance NavigationMixin to handle notifications

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e8010e4a44ec5acb0ae4f432a90d54525680559c
==========

[Brian Wilkerson, 2017-08-24 14:44:54]

Committed patchset #2 (id:20001) manually as
e8010e4a44ec5acb0ae4f432a90d54525680559c (presubmit successful).