Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: pkg/analyzer_plugin/lib/plugin/completion_mixin.dart

Issue 3008433002: Unify lots of copied code in one utility method (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_plugin/lib/plugin/assist_mixin.dart ('k') | pkg/analyzer_plugin/lib/plugin/fix_mixin.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_plugin/lib/plugin/completion_mixin.dart
diff --git a/pkg/analyzer_plugin/lib/plugin/completion_mixin.dart b/pkg/analyzer_plugin/lib/plugin/completion_mixin.dart
index a4008136658b4b22af8c706f439a2801739a61a9..ef2684ed986eb08c2b4e8456c19d26678517f9f7 100644
--- a/pkg/analyzer_plugin/lib/plugin/completion_mixin.dart
+++ b/pkg/analyzer_plugin/lib/plugin/completion_mixin.dart
@@ -30,6 +30,8 @@ abstract class CompletionMixin implements ServerPlugin {
/**
* Return the completion request that should be passes to the contributors
* returned from [getCompletionContributors].
+ *
+ * Throw a [RequestFailure] if the request could not be created.
*/
Future<CompletionRequest> getCompletionRequest(
CompletionGetSuggestionsParams parameters);
@@ -63,13 +65,7 @@ abstract class DartCompletionMixin implements CompletionMixin {
Future<CompletionRequest> getCompletionRequest(
CompletionGetSuggestionsParams parameters) async {
String path = parameters.file;
- AnalysisDriver driver = driverForPath(path);
- if (driver == null) {
- // Return an error from the request.
- throw new RequestFailure(
- RequestErrorFactory.pluginError('Failed to analyze $path', null));
- }
- ResolveResult result = await driver.getResult(parameters.file);
+ ResolveResult result = await getResolveResult(parameters.file);
return new DartCompletionRequestImpl(
resourceProvider, parameters.offset, result);
}
« no previous file with comments | « pkg/analyzer_plugin/lib/plugin/assist_mixin.dart ('k') | pkg/analyzer_plugin/lib/plugin/fix_mixin.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698