Issue 3008433002: Unify lots of copied code in one utility method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3008433002: Unify lots of copied code in one utility method (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson

Modified:
3 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, mfairhurst

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -36 lines)			Patch
M	pkg/analyzer_plugin/lib/plugin/assist_mixin.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	pkg/analyzer_plugin/lib/plugin/completion_mixin.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	pkg/analyzer_plugin/lib/plugin/fix_mixin.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	pkg/analyzer_plugin/lib/plugin/kythe_mixin.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	pkg/analyzer_plugin/lib/plugin/navigation_mixin.dart	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	pkg/analyzer_plugin/lib/plugin/plugin.dart	View	15 chunks	+53 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

3 years, 4 months ago (2017-08-23 21:25:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c53bc9f628055eb3caaf47194fe1c1d385834573 (presubmit successful).