Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc

Issue 300843013: Install and launch kiosk app from cached crx file at start up. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ExternalProviderImplChromeOSTest.AppMode test case. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc b/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
index bad7834f903a53a7ec43b85e8d62afdc21d3e0de..b056094de46327aa46fe68268a5f87719371cfde 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
@@ -484,8 +484,7 @@ IN_PROC_BROWSER_TEST_F(KioskAppManagerTest, UpdateAppDataFromProfile) {
EXPECT_EQ("Updated App1 Name", apps[0].name);
}
-// Test is flaky. See http://crbug.com/379769 for details.
-IN_PROC_BROWSER_TEST_F(KioskAppManagerTest, DISABLED_BadApp) {
+IN_PROC_BROWSER_TEST_F(KioskAppManagerTest, BadApp) {
AppDataLoadWaiter waiter(manager(), 2);
manager()->AddApp("unknown_app");
TestKioskAppManagerObserver observer(manager());
@@ -493,7 +492,7 @@ IN_PROC_BROWSER_TEST_F(KioskAppManagerTest, DISABLED_BadApp) {
EXPECT_FALSE(waiter.loaded());
EXPECT_EQ("", GetAppIds());
- EXPECT_EQ(1, observer.load_failure_count());
+ EXPECT_LE(1, observer.load_failure_count());
}
IN_PROC_BROWSER_TEST_F(KioskAppManagerTest, GoodApp) {

Powered by Google App Engine
This is Rietveld 408576698