Issue 300843012: Revert of Spin off just SkLazyFnPtr from 305513002.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300843012: Revert of Spin off just SkLazyFnPtr from 305513002. (Closed)

Created:
6 years, 6 months ago by mtklein

Modified:
6 years, 6 months ago

Reviewers:
bungeman-skia, mtklein_C

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Spin off just SkLazyFnPtr from 305513002. (https://codereview.chromium.org/305753002/) Reason for revert: depends on bad cl Original issue's description: > Spin off just SkLazyFnPtr from 305513002. > > The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in > SkUtils on ARM. We can do a lot better for function pointers. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14929 TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14933

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -94 lines)			Patch
D	src/core/SkLazyFnPtr.h	View	1 chunk	+0 lines, -58 lines	0 comments	Download
M	src/core/SkThread.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/core/SkUtils.cpp	View	2 chunks	+38 lines, -20 lines	0 comments	Download
M	src/ports/SkAtomics_sync.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/ports/SkAtomics_win.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Spin off just SkLazyFnPtr from 305513002.

6 years, 6 months ago (2014-05-28 19:57:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/300843012/1

6 years, 6 months ago (2014-05-28 19:58:06 UTC) #2

Message was sent while issue was closed.

Change committed as 14933