Issue 300843010: Change clip rect computation for multicol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300843010: Change clip rect computation for multicol (Closed)

Created:
6 years, 6 months ago by eae

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Change clip rect computation for multicol Change the way clip rects are determined for multicol by using enclosing IntRect instead of pixelSnappedIntRect to ensure that the colum contents fully fits within the clip rect. R=leviw@chromium.org, mstensho@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174983

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/300843010/30001

6 years, 6 months ago (2014-05-28 17:27:27 UTC) #3

eae

6 years, 6 months ago (2014-05-28 18:21:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r174983 (presubmit successful).

Expand Messages | Collapse Messages