Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 300843004: Don't sync typed URL modification that doesn't have valid visits, which could (Closed)

Created:
6 years, 7 months ago by haitaol1
Modified:
6 years, 6 months ago
Reviewers:
rlarocque, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Don't sync typed URL modification that doesn't have valid visits, which could happen if the URL is bookmarked and all its visits are deleted. BUG=377711 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273925

Patch Set 1 #

Patch Set 2 : tst #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
haitaol1
6 years, 7 months ago (2014-05-27 21:44:46 UTC) #1
rlarocque
I think that looks OK, but I'd feel better about it if someone who knows ...
6 years, 7 months ago (2014-05-27 21:56:44 UTC) #2
haitaol1
On 2014/05/27 21:56:44, rlarocque wrote: > I think that looks OK, but I'd feel better ...
6 years, 7 months ago (2014-05-27 23:32:51 UTC) #3
haitaol1
ping
6 years, 6 months ago (2014-05-29 17:29:46 UTC) #4
rlarocque
Nicolas claims that he doesn't know this code very well, either. He's OOO today, so ...
6 years, 6 months ago (2014-05-30 17:32:33 UTC) #5
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 6 months ago (2014-05-30 17:38:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/300843004/20001
6 years, 6 months ago (2014-05-30 17:41:32 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 23:10:06 UTC) #8
Message was sent while issue was closed.
Change committed as 273925

Powered by Google App Engine
This is Rietveld 408576698