Issue 3008010: [Mac] Minor tweaks to the Wrench menu.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3008010: [Mac] Minor tweaks to the Wrench menu. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Robert Sesek

Modified:
4 years ago

Reviewers:
viettrungluu

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Minor tweaks to the Wrench menu. * Swap the +/- zoom buttons so that minus is first. * Invert the fullscreen arrows when in fullscreen mode. BUG=49449 TEST=Visual TEST=Wrench menu --> Enter full screen. Wrench menu now has inverted arrows to exit full screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52963

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
M	chrome/app/nibs/Toolbar.xib	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/wrench_menu_controller.mm	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/wrench_menu_model.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM with stuff fixed. http://codereview.chromium.org/3008010/diff/1/3 File chrome/browser/cocoa/wrench_menu_controller.mm (right): http://codereview.chromium.org/3008010/diff/1/3#newcode10 chrome/browser/cocoa/wrench_menu_controller.mm:10: #include "chrome/browser/browser.h" These #includes make ...

4 years, 10 months ago (2010-07-19 20:43:00 UTC) #2

Robert Sesek

4 years, 10 months ago (2010-07-19 21:11:50 UTC) #3

Addressed nits.

http://codereview.chromium.org/3008010/diff/1/3
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3008010/diff/1/3#newcode10
chrome/browser/cocoa/wrench_menu_controller.mm:10: #include
"chrome/browser/browser.h"
On 2010/07/19 20:43:00, viettrungluu wrote:
> These #includes make me sad; there's a way around it, but the cure is probably
> worse than the disease.

What's the "cure"?  Just curious, but if you say it's worse then it's probably
not worth doing.

Expand Messages | Collapse Messages