Chromium Code Reviews
Help | Chromium Project | Sign in
(72)

Issue 3008010: [Mac] Minor tweaks to the Wrench menu. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Robert Sesek
Modified:
4 years ago
Reviewers:
viettrungluu
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

[Mac] Minor tweaks to the Wrench menu. * Swap the +/- zoom buttons so that minus is first. * Invert the fullscreen arrows when in fullscreen mode. BUG=49449 TEST=Visual TEST=Wrench menu --> Enter full screen. Wrench menu now has inverted arrows to exit full screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52963

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/app/nibs/Toolbar.xib View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/wrench_menu_controller.mm View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/wrench_menu_model.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Robert Sesek
4 years, 10 months ago (2010-07-19 19:15:30 UTC) #1
viettrungluu
LGTM with stuff fixed. http://codereview.chromium.org/3008010/diff/1/3 File chrome/browser/cocoa/wrench_menu_controller.mm (right): http://codereview.chromium.org/3008010/diff/1/3#newcode10 chrome/browser/cocoa/wrench_menu_controller.mm:10: #include "chrome/browser/browser.h" These #includes make ...
4 years, 10 months ago (2010-07-19 20:43:00 UTC) #2
Robert Sesek
4 years, 10 months ago (2010-07-19 21:11:50 UTC) #3
Addressed nits.

http://codereview.chromium.org/3008010/diff/1/3
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3008010/diff/1/3#newcode10
chrome/browser/cocoa/wrench_menu_controller.mm:10: #include
"chrome/browser/browser.h"
On 2010/07/19 20:43:00, viettrungluu wrote:
> These #includes make me sad; there's a way around it, but the cure is probably
> worse than the disease.

What's the "cure"?  Just curious, but if you say it's worse then it's probably
not worth doing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be