[Mac] Minor tweaks to the Wrench menu.

[Mac] Minor tweaks to the Wrench menu.

* Swap the +/- zoom buttons so that minus is first.
* Invert the fullscreen arrows when in fullscreen mode.

BUG=49449
TEST=Visual
TEST=Wrench menu --> Enter full screen. Wrench menu now has inverted arrows to exit full screen.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52963

[viettrungluu, 2010-07-19 20:43:00]

LGTM with stuff fixed.

http://codereview.chromium.org/3008010/diff/1/3
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3008010/diff/1/3#newcode10
chrome/browser/cocoa/wrench_menu_controller.mm:10: #include
"chrome/browser/browser.h"
These #includes make me sad; there's a way around it, but the cure is probably
worse than the disease.

http://codereview.chromium.org/3008010/diff/1/3#newcode76
chrome/browser/cocoa/wrench_menu_controller.mm:76: if ([self
wrenchMenuModel]->browser()->window()->IsFullscreen()) {
I think I'd prefer:

bool isFullscreen = ...;
[zoomFullScreen_ setImage:[NSImage imageNamed:(isFullscreen ? ... : ...)]];

(or even with an added temporary variable with NSImage).

http://codereview.chromium.org/3008010/diff/1/4
File chrome/browser/wrench_menu_model.h (right):

http://codereview.chromium.org/3008010/diff/1/4#newcode82
chrome/browser/wrench_menu_model.h:82: Browser* browser() { return browser_; }
browser() const

[Robert Sesek, 2010-07-19 21:11:50]

Addressed nits.

http://codereview.chromium.org/3008010/diff/1/3
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3008010/diff/1/3#newcode10
chrome/browser/cocoa/wrench_menu_controller.mm:10: #include
"chrome/browser/browser.h"
On 2010/07/19 20:43:00, viettrungluu wrote:
> These #includes make me sad; there's a way around it, but the cure is probably
> worse than the disease.

What's the "cure"?  Just curious, but if you say it's worse then it's probably
not worth doing.