gracefully recover from extraneous top level modifiers

pkg/analyzer/test/generated/parser_fasta_test.dart

Index: pkg/analyzer/test/generated/parser_fasta_test.dart
diff --git a/pkg/analyzer/test/generated/parser_fasta_test.dart b/pkg/analyzer/test/generated/parser_fasta_test.dart
index 6a8c7514a67a6e12e844a1c095e6fb136588dafa..972a7118e34029857ee53f9f742f23cf99766d3c 100644
--- a/pkg/analyzer/test/generated/parser_fasta_test.dart
+++ b/pkg/analyzer/test/generated/parser_fasta_test.dart
@@ -204,6 +204,8 @@ class ErrorParserTest_Fasta extends FastaParserTestCase
   @override
   @failingTest
   void test_constClass() {
+    // TODO(danrubel): Rather than reporting ParserErrorCode.EXTRANEOUS_MODIFIER
+    // report ParserErrorCode.CONST_CLASS to better help the user
     super.test_constClass();
   }
 
@@ -213,12 +215,6 @@ class ErrorParserTest_Fasta extends FastaParserTestCase
     super.test_constConstructorWithBody();
   }
 
-  @override
-  @failingTest
-  void test_constEnum() {
-    super.test_constEnum();
-  }
-
   @override
   @failingTest
   void test_constFactory() {
@@ -243,12 +239,6 @@ class ErrorParserTest_Fasta extends FastaParserTestCase
     super.test_constructorWithReturnType_var();
   }
 
-  @override
-  @failingTest
-  void test_constTypedef() {
-    super.test_constTypedef();
-  }
-
   @override
   @failingTest
   void test_continueOutsideOfLoop_continueInDoStatement() {
@@ -765,36 +755,18 @@ class ErrorParserTest_Fasta extends FastaParserTestCase
     super.test_finalAndVar();
   }
 
-  @override
-  @failingTest
-  void test_finalClass() {
-    super.test_finalClass();
-  }
-
   @override
   @failingTest
   void test_finalConstructor() {
     super.test_finalConstructor();
   }
 
-  @override
-  @failingTest
-  void test_finalEnum() {
-    super.test_finalEnum();
-  }
-
   @override
   @failingTest
   void test_finalMethod() {
     super.test_finalMethod();
   }
 
-  @override
-  @failingTest
-  void test_finalTypedef() {
-    super.test_finalTypedef();
-  }
-
   @override
   @failingTest
   void test_functionTypedParameter_const() {
@@ -1654,36 +1626,6 @@ class ErrorParserTest_Fasta extends FastaParserTestCase
     super.test_staticSetterWithoutBody();
   }
 
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_class() {
-    super.test_staticTopLevelDeclaration_class();
-  }
-
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_enum() {
-    super.test_staticTopLevelDeclaration_enum();
-  }
-
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_function() {
-    super.test_staticTopLevelDeclaration_function();
-  }
-
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_typedef() {
-    super.test_staticTopLevelDeclaration_typedef();
-  }
-
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_variable() {
-    super.test_staticTopLevelDeclaration_variable();
-  }
-
   @override
   @failingTest
   void test_string_unterminated_interpolation_block() {
@@ -2494,7 +2436,13 @@ class FastaParserTestCase extends Object
             code == ParserErrorCode.ABSTRACT_ENUM ||
             code == ParserErrorCode.ABSTRACT_TOP_LEVEL_FUNCTION ||
             code == ParserErrorCode.ABSTRACT_TOP_LEVEL_VARIABLE ||
-            code == ParserErrorCode.ABSTRACT_TYPEDEF)
+            code == ParserErrorCode.ABSTRACT_TYPEDEF ||
+            code == ParserErrorCode.CONST_ENUM ||
+            code == ParserErrorCode.CONST_TYPEDEF ||
+            code == ParserErrorCode.FINAL_CLASS ||
+            code == ParserErrorCode.FINAL_ENUM ||
+            code == ParserErrorCode.FINAL_TYPEDEF ||
+            code == ParserErrorCode.STATIC_TOP_LEVEL_DECLARATION)
           return ParserErrorCode.EXTRANEOUS_MODIFIER;
         return code;
       }).toList();
@@ -4294,19 +4242,31 @@ class TopLevelParserTest_Fasta extends FastaParserTestCase
   }
 
   @override
-  @failingTest
-  void test_parseCompilationUnit_abstractAsPrefix_parameterized() {
-    // TODO(danrubel): built-in "abstract" cannot be used as a type
-    super.test_parseCompilationUnit_abstractAsPrefix_parameterized();
-  }
-
-  @override
-  @failingTest
   void test_parseCompilationUnit_builtIn_asFunctionName() {
+    //super.test_parseCompilationUnit_builtIn_asFunctionName();

[Brian Wilkerson, 2017/08/31 20:05:52]

Perhaps a comment explaining that this is the subset that now pass and that the
failing identifiers are in test_parseCompilationUnit_builtIn_asFunctionName2?

[danrubel, 2017/08/31 21:24:53]

Good idea. Done.

+    parseCompilationUnit('abstract(x) => 0;');
+    parseCompilationUnit('as(x) => 0;');
+    parseCompilationUnit('dynamic(x) => 0;');
+    parseCompilationUnit('external(x) => 0;');
+    parseCompilationUnit('factory(x) => 0;');
+    parseCompilationUnit('get(x) => 0;');
+    parseCompilationUnit('implements(x) => 0;');
+    parseCompilationUnit('operator(x) => 0;');
+    parseCompilationUnit('set(x) => 0;');
+    parseCompilationUnit('static(x) => 0;');
+    parseCompilationUnit('static(abstract) => 0;');
+    parseCompilationUnit('typedef(x) => 0;');
+  }
+
+  @failingTest
+  void test_parseCompilationUnit_builtIn_asFunctionName2() {
     // TODO(paulberry,ahe): Fasta's parser is confused when one of the built-in
     // identifiers `export`, `import`, `library`, `part`, or `typedef` appears
     // as the name of a top level function with an implicit return type.
-    super.test_parseCompilationUnit_builtIn_asFunctionName();
+    parseCompilationUnit('export(x) => 0;');
+    parseCompilationUnit('import(x) => 0;');
+    parseCompilationUnit('library(x) => 0;');
+    parseCompilationUnit('part(x) => 0;');
   }
 
   @override