Support annotations on assignment and postfix operations

Support annotations on assignment and postfix operations

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/f97a961cbecdf10186abbbbb2028fefdd9126259

[Johnni Winther, 2017-08-31 13:51:26]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-31 23:04:03]

lgtm with comment

https://codereview.chromium.org/3007903002/diff/1/tests/compiler/dart2js/equi...
File tests/compiler/dart2js/equivalence/id_equivalence.dart (right):

https://codereview.chromium.org/3007903002/diff/1/tests/compiler/dart2js/equi...
tests/compiler/dart2js/equivalence/id_equivalence.dart:44: return
'${elementId.name}:$value';
to make it easier to understand the ID when reading the test samples, consider
using just a word instead. For example:

'element: Sub.method value'
'node: value'
'invoke: value'
'update: value'

Thoughts?

[Johnni Winther, 2017-09-01 14:00:03]

https://codereview.chromium.org/3007903002/diff/1/tests/compiler/dart2js/equi...
File tests/compiler/dart2js/equivalence/id_equivalence.dart (right):

https://codereview.chromium.org/3007903002/diff/1/tests/compiler/dart2js/equi...
tests/compiler/dart2js/equivalence/id_equivalence.dart:44: return
'${elementId.name}:$value';
On 2017/08/31 23:04:03, Siggi Cherem (dart-lang) wrote:
> to make it easier to understand the ID when reading the test samples, consider
> using just a word instead. For example:
> 
> 'element: Sub.method value'
> 'node: value'
> 'invoke: value'
> 'update: value'
> 
> Thoughts?

Good idea. Encoding changed to

'element: Sub.method:value'
'value'
'invoke: value'
'update: value'

respectively. The kind 'node' is just for non-specific data so I omitted a
prefix for that one.

[Johnni Winther, 2017-09-01 14:39:58]

Description was changed from

==========
Support annotations on assignment and postfix operations
==========

to

==========
Support annotations on assignment and postfix operations

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f97a961cbecdf10186abbbbb2028fefdd9126259
==========

[Johnni Winther, 2017-09-01 14:40:01]

Committed patchset #2 (id:20001) manually as
f97a961cbecdf10186abbbbb2028fefdd9126259 (presubmit successful).