Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 300783002: Make fast/dom/inline-attributes-release.html deterministic by making (Closed)

Created:
6 years, 7 months ago by Mads Ager (chromium)
Modified:
6 years, 7 months ago
Reviewers:
haraken, zerny-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Make fast/dom/inline-attributes-release.html deterministic by making sure that we get precise GCs before testing that objects disappear. This test is flaky on the buildbot because the GCs forced in the test are conservative. Make the precise by using asyncGC. R=haraken@chromium.org, zerny@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M LayoutTests/fast/dom/inline-event-attributes-release.html View 1 chunk +18 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mads Ager (chromium)
6 years, 7 months ago (2014-05-27 11:35:38 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-27 11:36:35 UTC) #2
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 7 months ago (2014-05-27 11:37:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/300783002/1
6 years, 7 months ago (2014-05-27 11:37:28 UTC) #4
zerny-chromium
lgtm
6 years, 7 months ago (2014-05-27 11:38:39 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 13:11:20 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 13:49:50 UTC) #7
Message was sent while issue was closed.
Change committed as 174861

Powered by Google App Engine
This is Rietveld 408576698