Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: tests/compiler/dart2js/equivalence/id_equivalence.dart

Issue 3007783004: Handle switch continue (Closed)
Patch Set: Updated cf. comment Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/equivalence/id_equivalence.dart
diff --git a/tests/compiler/dart2js/equivalence/id_equivalence.dart b/tests/compiler/dart2js/equivalence/id_equivalence.dart
index 9d6d5d0cf757eec25868a023e5364c98bfb4b4eb..ed2a9dccd4c01574744c13b9461e3731a9147262 100644
--- a/tests/compiler/dart2js/equivalence/id_equivalence.dart
+++ b/tests/compiler/dart2js/equivalence/id_equivalence.dart
@@ -157,12 +157,23 @@ abstract class AstDataExtractor extends ast.Visitor {
return new NodeId(node.getBeginToken().charOffset);
}
- NodeId computeLoopNodeId(ast.Node node) {
- return new NodeId(node.getBeginToken().charOffset);
- }
+ NodeId computeLoopNodeId(ast.Node node) => computeDefaultNodeId(node);
- NodeId computeGotoNodeId(ast.Node node) {
- return new NodeId(node.getBeginToken().charOffset);
+ NodeId computeGotoNodeId(ast.Node node) => computeDefaultNodeId(node);
+
+ NodeId computeSwitchNodeId(ast.SwitchStatement node) =>
+ computeDefaultNodeId(node);
+
+ NodeId computeSwitchCaseNodeId(ast.SwitchCase node) {
+ ast.Node position;
+ for (ast.Node child in node.labelsAndCases) {
+ if (child.asCaseMatch() != null) {
+ ast.CaseMatch caseMatch = child;
+ position = caseMatch.expression;
+ break;
+ }
+ }
+ return computeDefaultNodeId(position);
}
void run() {
@@ -223,6 +234,16 @@ abstract class AstDataExtractor extends ast.Visitor {
computeForNode(node, computeGotoNodeId(node));
visitNode(node);
}
+
+ visitSwitchStatement(ast.SwitchStatement node) {
+ computeForNode(node, computeSwitchNodeId(node));
+ visitNode(node);
+ }
+
+ visitSwitchCase(ast.SwitchCase node) {
+ computeForNode(node, computeSwitchCaseNodeId(node));
+ visitNode(node);
+ }
}
/// Abstract IR visitor for computing data corresponding to a node or element,
@@ -285,6 +306,10 @@ abstract class IrDataExtractor extends ir.Visitor {
NodeId computeLoopNodeId(ir.TreeNode node) => computeDefaultNodeId(node);
NodeId computeGotoNodeId(ir.TreeNode node) => computeDefaultNodeId(node);
+ NodeId computeSwitchNodeId(ir.SwitchStatement node) =>
+ computeDefaultNodeId(node);
+ NodeId computeSwitchCaseNodeId(ir.SwitchCase node) =>
+ new NodeId(node.expressionOffsets.first);
void run(ir.Node root) {
root.accept(this);
@@ -353,4 +378,19 @@ abstract class IrDataExtractor extends ir.Visitor {
computeForNode(node, computeGotoNodeId(node));
super.visitBreakStatement(node);
}
+
+ visitSwitchStatement(ir.SwitchStatement node) {
+ computeForNode(node, computeSwitchNodeId(node));
+ super.visitSwitchStatement(node);
+ }
+
+ visitSwitchCase(ir.SwitchCase node) {
+ computeForNode(node, computeSwitchCaseNodeId(node));
+ super.visitSwitchCase(node);
+ }
+
+ visitContinueSwitchStatement(ir.ContinueSwitchStatement node) {
+ computeForNode(node, computeGotoNodeId(node));
+ super.visitContinueSwitchStatement(node);
+ }
}
« no previous file with comments | « tests/compiler/dart2js/closure/closure_test.dart ('k') | tests/compiler/dart2js/equivalence/id_equivalence_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698