Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 3007783004: Handle switch continue (Closed)

Created:
3 years, 3 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -39 lines) Patch
M pkg/compiler/lib/src/js_model/locals.dart View 3 chunks +17 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/jump_handler.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence.dart View 1 4 chunks +45 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_helper.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_test.dart View 3 chunks +14 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/inference/inference_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/jumps/data/switch.dart View 4 chunks +17 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/jumps/jump_test.dart View 4 chunks +39 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 3 months ago (2017-08-30 13:48:44 UTC) #2
Siggi Cherem (dart-lang)
lgtm with comment https://codereview.chromium.org/3007783004/diff/1/tests/compiler/dart2js/equivalence/id_equivalence.dart File tests/compiler/dart2js/equivalence/id_equivalence.dart (right): https://codereview.chromium.org/3007783004/diff/1/tests/compiler/dart2js/equivalence/id_equivalence.dart#newcode252 tests/compiler/dart2js/equivalence/id_equivalence.dart:252: computeForNode(node, computeDefaultNodeId(position)); use computeSwitchCaseNodeId here?
3 years, 3 months ago (2017-08-30 20:17:29 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 40858f5f50e6408394f07160fa43f1a8802c2499 (presubmit successful).
3 years, 3 months ago (2017-08-31 10:32:10 UTC) #5
Johnni Winther
3 years, 3 months ago (2017-08-31 11:03:36 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/3007783004/diff/1/tests/compiler/dart2js/equi...
File tests/compiler/dart2js/equivalence/id_equivalence.dart (right):

https://codereview.chromium.org/3007783004/diff/1/tests/compiler/dart2js/equi...
tests/compiler/dart2js/equivalence/id_equivalence.dart:252: computeForNode(node,
computeDefaultNodeId(position));
On 2017/08/30 20:17:29, Siggi Cherem (dart-lang) wrote:
> use computeSwitchCaseNodeId here?

Done.

Powered by Google App Engine
This is Rietveld 408576698