Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3007783002: Add fixes for two additional lints (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -14 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 4 chunks +41 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +9 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +58 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-08-29 14:35:28 UTC) #2
scheglov
LGTM https://codereview.chromium.org/3007783002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/3007783002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode5840 pkg/analysis_server/test/services/correction/fix_test.dart:5840: } else /*LINT*/; Is the lint reported for ...
3 years, 3 months ago (2017-08-29 17:05:22 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/3007783002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/3007783002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode5840 pkg/analysis_server/test/services/correction/fix_test.dart:5840: } else /*LINT*/; It isn't currently, but I think ...
3 years, 3 months ago (2017-08-29 17:16:46 UTC) #4
Brian Wilkerson
3 years, 3 months ago (2017-08-29 17:18:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
170c562ffe4ccd02567e5f084e919545ef9d9b6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698