[dart:io] Namespaces for file IO

runtime/bin/process.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/process.h"
 
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
 #include "bin/log.h"
+#include "bin/namespace.h"
 #include "bin/platform.h"
 #include "bin/socket.h"
 #include "bin/utils.h"
 
 #include "include/dart_api.h"
 
 namespace dart {
 namespace bin {
 
 static const int kProcessIdNativeField = 0;
@@ skipping 55 matching lines @@
     ClearSignalHandler(i, ILLEGAL_PORT);
   }
 }
 
 void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
   Dart_Handle process = Dart_GetNativeArgument(args, 0);
   intptr_t process_stdin;
   intptr_t process_stdout;
   intptr_t process_stderr;
   intptr_t exit_event;
-  Dart_Handle result;
-  Dart_Handle status_handle = Dart_GetNativeArgument(args, 10);
-  Dart_Handle path_handle = Dart_GetNativeArgument(args, 1);
+  Namespace* namespc = Namespace::GetNamespace(args, 1);
+  Dart_Handle status_handle = Dart_GetNativeArgument(args, 11);
+  Dart_Handle path_handle = Dart_GetNativeArgument(args, 2);
   // The Dart code verifies that the path implements the String
   // interface. However, only builtin Strings are handled by
   // GetStringValue.
+  Dart_Handle result;
   if (!Dart_IsString(path_handle)) {
     result = DartUtils::SetIntegerField(status_handle, "_errorCode", 0);
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
     result = DartUtils::SetStringField(status_handle, "_errorMessage",
                                        "Path must be a builtin string");
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
-    Dart_SetReturnValue(args, Dart_NewBoolean(false));
+    Dart_SetBooleanReturnValue(args, false);
     return;
   }
   const char* path = DartUtils::GetStringValue(path_handle);
-  Dart_Handle arguments = Dart_GetNativeArgument(args, 2);
+  Dart_Handle arguments = Dart_GetNativeArgument(args, 3);
   intptr_t args_length = 0;
   char** string_args =
       ExtractCStringList(arguments, status_handle,
                          "Arguments must be builtin strings", &args_length);
   if (string_args == NULL) {
-    Dart_SetReturnValue(args, Dart_NewBoolean(false));
+    Dart_SetBooleanReturnValue(args, false);
     return;
   }
-  Dart_Handle working_directory_handle = Dart_GetNativeArgument(args, 3);
+  Dart_Handle working_directory_handle = Dart_GetNativeArgument(args, 4);
   // Defaults to the current working directoy.
   const char* working_directory = NULL;
   if (Dart_IsString(working_directory_handle)) {
     working_directory = DartUtils::GetStringValue(working_directory_handle);
   } else if (!Dart_IsNull(working_directory_handle)) {
     result = DartUtils::SetIntegerField(status_handle, "_errorCode", 0);
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
     result =
         DartUtils::SetStringField(status_handle, "_errorMessage",
                                   "WorkingDirectory must be a builtin string");
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
-    Dart_SetReturnValue(args, Dart_NewBoolean(false));
+    Dart_SetBooleanReturnValue(args, false);
     return;
   }
-  Dart_Handle environment = Dart_GetNativeArgument(args, 4);
+  Dart_Handle environment = Dart_GetNativeArgument(args, 5);
   intptr_t environment_length = 0;
   char** string_environment = NULL;
   if (!Dart_IsNull(environment)) {
     string_environment = ExtractCStringList(
         environment, status_handle,
         "Environment values must be builtin strings", &environment_length);
     if (string_environment == NULL) {
       Dart_SetReturnValue(args, Dart_NewBoolean(false));
       return;
     }
   }
   int64_t mode =
-      DartUtils::GetInt64ValueCheckRange(Dart_GetNativeArgument(args, 5), 0, 2);
-  Dart_Handle stdin_handle = Dart_GetNativeArgument(args, 6);
-  Dart_Handle stdout_handle = Dart_GetNativeArgument(args, 7);
-  Dart_Handle stderr_handle = Dart_GetNativeArgument(args, 8);
-  Dart_Handle exit_handle = Dart_GetNativeArgument(args, 9);
+      DartUtils::GetInt64ValueCheckRange(Dart_GetNativeArgument(args, 6), 0, 2);
+  Dart_Handle stdin_handle = Dart_GetNativeArgument(args, 7);
+  Dart_Handle stdout_handle = Dart_GetNativeArgument(args, 8);
+  Dart_Handle stderr_handle = Dart_GetNativeArgument(args, 9);
+  Dart_Handle exit_handle = Dart_GetNativeArgument(args, 10);
   intptr_t pid = -1;
   char* os_error_message = NULL;  // Scope allocated by Process::Start.
 
   int error_code = Process::Start(
-      path, string_args, args_length, working_directory, string_environment,
-      environment_length, static_cast<ProcessStartMode>(mode), &process_stdout,
-      &process_stdin, &process_stderr, &pid, &exit_event, &os_error_message);
+      namespc, path, string_args, args_length, working_directory,
+      string_environment, environment_length,
+      static_cast<ProcessStartMode>(mode), &process_stdout, &process_stdin,
+      &process_stderr, &pid, &exit_event, &os_error_message);
   if (error_code == 0) {
     if (mode != kDetached) {
       Socket::SetSocketIdNativeField(stdin_handle, process_stdin,
                                      Socket::kFinalizerNormal);
       Socket::SetSocketIdNativeField(stdout_handle, process_stdout,
                                      Socket::kFinalizerNormal);
       Socket::SetSocketIdNativeField(stderr_handle, process_stderr,
                                      Socket::kFinalizerNormal);
     }
     if (mode == kNormal) {
       Socket::SetSocketIdNativeField(exit_handle, exit_event,
                                      Socket::kFinalizerNormal);
     }
     Process::SetProcessIdNativeField(process, pid);
   } else {
     result =
         DartUtils::SetIntegerField(status_handle, "_errorCode", error_code);
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
     result = DartUtils::SetStringField(status_handle, "_errorMessage",
                                        os_error_message != NULL
                                            ? os_error_message
                                            : "Cannot get error message");
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
   }
-  Dart_SetReturnValue(args, Dart_NewBoolean(error_code == 0));
+  Dart_SetBooleanReturnValue(args, error_code == 0);
 }
 
 void FUNCTION_NAME(Process_Wait)(Dart_NativeArguments args) {
   Dart_Handle process = Dart_GetNativeArgument(args, 0);
   Socket* process_stdin =
       Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 1));
   Socket* process_stdout =
       Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 2));
   Socket* process_stderr =
       Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 3));
@@ skipping 29 matching lines @@
     Dart_Handle error = DartUtils::NewDartOSError();
     Process::Kill(pid, 9);
     Dart_ThrowException(error);
   }
 }
 
 void FUNCTION_NAME(Process_KillPid)(Dart_NativeArguments args) {
   intptr_t pid = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 0));
   intptr_t signal = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 1));
   bool success = Process::Kill(pid, signal);
-  Dart_SetReturnValue(args, Dart_NewBoolean(success));
+  Dart_SetBooleanReturnValue(args, success);
 }
 
 void FUNCTION_NAME(Process_Exit)(Dart_NativeArguments args) {
   int64_t status = 0;
   // Ignore result if passing invalid argument and just exit 0.
   DartUtils::GetInt64Value(Dart_GetNativeArgument(args, 0), &status);
   Process::RunExitHook(status);
   Dart_ExitIsolate();
   Platform::Exit(static_cast<int>(status));
 }
 
 void FUNCTION_NAME(Process_SetExitCode)(Dart_NativeArguments args) {
   int64_t status = 0;
   // Ignore result if passing invalid argument and just set exit code to 0.
   DartUtils::GetInt64Value(Dart_GetNativeArgument(args, 0), &status);
   Process::SetGlobalExitCode(status);
 }
 
 void FUNCTION_NAME(Process_GetExitCode)(Dart_NativeArguments args) {
-  Dart_SetReturnValue(args, Dart_NewInteger(Process::GlobalExitCode()));
+  Dart_SetIntegerReturnValue(args, Process::GlobalExitCode());
 }
 
 void FUNCTION_NAME(Process_Sleep)(Dart_NativeArguments args) {
   ScopedBlockingCall blocker;
   int64_t milliseconds = 0;
   // Ignore result if passing invalid argument and just set exit code to 0.
   DartUtils::GetInt64Value(Dart_GetNativeArgument(args, 0), &milliseconds);
   TimerUtils::Sleep(milliseconds);
 }
 
 void FUNCTION_NAME(Process_Pid)(Dart_NativeArguments args) {
   // Ignore result if passing invalid argument and just set exit code to 0.
   intptr_t pid = -1;
   Dart_Handle process = Dart_GetNativeArgument(args, 0);
   if (Dart_IsNull(process)) {
     pid = Process::CurrentProcessId();
   } else {
     Process::GetProcessIdNativeField(process, &pid);
   }
-  Dart_SetReturnValue(args, Dart_NewInteger(pid));
+  Dart_SetIntegerReturnValue(args, pid);
 }
 
 void FUNCTION_NAME(Process_SetSignalHandler)(Dart_NativeArguments args) {
   intptr_t signal = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 0));
   intptr_t id = Process::SetSignalHandler(signal);
   if (id == -1) {
     Dart_SetReturnValue(args, DartUtils::NewDartOSError());
   } else {
-    Dart_SetReturnValue(args, Dart_NewInteger(id));
+    Dart_SetIntegerReturnValue(args, id);
   }
 }
 
 void FUNCTION_NAME(Process_ClearSignalHandler)(Dart_NativeArguments args) {
   intptr_t signal = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 0));
   Process::ClearSignalHandler(signal, Dart_GetMainPortId());
 }
 
 Dart_Handle Process::GetProcessIdNativeField(Dart_Handle process,
                                              intptr_t* pid) {
@@ skipping 73 matching lines @@
 
 void Process::GetRSSInformation(int64_t* max_rss, int64_t* current_rss) {
   ASSERT(max_rss != NULL);
   ASSERT(current_rss != NULL);
   *max_rss = Process::MaxRSS();
   *current_rss = Process::CurrentRSS();
 }
 
 }  // namespace bin
 }  // namespace dart