Fix many bugs with closure conversion in checked mode.

runtime/vm/kernel_binary_flowgraph.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/kernel_binary_flowgraph.h"
 #include "vm/compiler.h"
 #include "vm/longjump.h"
 #include "vm/object_store.h"
 
 #if !defined(DART_PRECOMPILED_RUNTIME)
@@ skipping 6391 matching lines @@
   instructions += LoadLocal(closure);
   instructions += Constant(function);
   instructions +=
       StoreInstanceField(TokenPosition::kNoSource, Closure::function_offset());
 
   instructions += LoadLocal(closure);
   instructions += LoadLocal(context);
   instructions +=
       StoreInstanceField(TokenPosition::kNoSource, Closure::context_offset());
 
-  instructions += Drop();
-
   SkipDartType();  // skip function type of the closure.
 
   // TODO(30455): Kernel generic methods undone. When generic methods are
   // fully supported in kernel, we'll need to store a NULL in the type arguments
   // slot when type arguments are absent, so the wrapper for the target function
   // can tell how many type args are captured vs. provided by the caller of the
   // closure.
 
   intptr_t types_count = ReadListLength();  // read type count.
   if (types_count > 0) {
-    instructions += LoadLocal(context);
-
     const TypeArguments& type_args =
         T.BuildTypeArguments(types_count);  // read list of type arguments.
     instructions += TranslateInstantiatedTypeArguments(type_args);
+    LocalVariable* type_args_slot = MakeTemporary();
 
+    instructions += LoadLocal(context);
+    instructions += LoadLocal(type_args_slot);
     instructions += StoreInstanceField(TokenPosition::kNoSource,
                                        Context::variable_offset(0));
+
+    instructions += LoadLocal(closure);
+    instructions += LoadLocal(type_args_slot);
+    instructions += StoreInstanceField(
+        TokenPosition::kNoSource, Closure::function_type_arguments_offset());
+
+    instructions += Drop();  // type args
   }
 
+  instructions += Drop();  // context
   return instructions;
 }
 
 Fragment StreamingFlowGraphBuilder::BuildInvalidStatement() {
   H.ReportError("Invalid statements not implemented yet!");
   return Fragment();
 }
 
 Fragment StreamingFlowGraphBuilder::BuildExpressionStatement() {
   Fragment instructions = BuildExpression();  // read expression.
@@ skipping 1377 matching lines @@
     }
   }
 
   return Array::Handle(Array::null());
 }
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)