Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 3007583002: Don't print "Necessary status file updates:" if there are none. (Closed)

Created:
3 years, 3 months ago by Bob Nystrom
Modified:
3 years, 3 months ago
Reviewers:
jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't print "Necessary status file updates:" if there are none. Also cleaned up the surrounding code to be more idiomatic. R=jcollins@google.com Committed: https://github.com/dart-lang/sdk/commit/58b96b7e6056487df1ebd31049e638afc0db0b3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M tools/testing/dart/test_progress.dart View 1 chunk +14 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 3 months ago (2017-08-25 22:44:43 UTC) #2
jcollins
lgtm
3 years, 3 months ago (2017-08-28 15:24:22 UTC) #3
Bob Nystrom
3 years, 3 months ago (2017-08-28 23:31:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58b96b7e6056487df1ebd31049e638afc0db0b3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698