Issue 3007533002: Address additional comments on nullability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3007533002: Address additional comments on nullability (Closed)

Created:
3 years, 3 months ago by Leaf

Modified:
3 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Address additional comments on nullability Address some post-submit comments on a previous CL, and fix some unrelated analyzer hints in passing. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/19a1393ae75a04618ee76123f92ba0710e5fbfb7

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -21 lines)			Patch
M	pkg/dev_compiler/bin/dartdevc.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/command.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/element_helpers.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/nullable_type_inference.dart	View	1 chunk	+5 lines, -8 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/reify_coercions.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/annotations.dart	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Leaf

3 years, 3 months ago (2017-08-24 22:37:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
19a1393ae75a04618ee76123f92ba0710e5fbfb7 (presubmit successful).