Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 300753002: Fix PathTracer. (Closed)

Created:
6 years, 6 months ago by Yang
Modified:
6 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix PathTracer. When tracing, we abuse the map for marking, thereby mutating it. FixedTypedArrayBase::size() uses the object's map, which causes crash. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21523

Patch Set 1 #

Patch Set 2 : also, test case. #

Total comments: 1

Patch Set 3 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M src/objects.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 4 chunks +15 lines, -5 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 6 months ago (2014-05-27 09:36:52 UTC) #1
Michael Starzinger
LGTM with suggestion. https://codereview.chromium.org/300753002/diff/20001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/300753002/diff/20001/src/objects.h#newcode5080 src/objects.h:5080: inline int SizeFromMap(Map* map); nit: Instead ...
6 years, 6 months ago (2014-05-27 12:19:55 UTC) #2
Yang
On 2014/05/27 12:19:55, Michael Starzinger wrote: > LGTM with suggestion. > > https://codereview.chromium.org/300753002/diff/20001/src/objects.h > File ...
6 years, 6 months ago (2014-05-27 13:04:11 UTC) #3
Yang
6 years, 6 months ago (2014-05-27 13:05:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21523 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698