Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 3007503002: Load extraRequiredLibraries from the target passed in the options (Closed)

Created:
3 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 3 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Load extraRequiredLibraries from the target passed in the options This makes the behavior match what fasta does. Long term I agree we don't want these implicit imports. I sent an email to brainstorm a solution for that. This change will address one of the issues reported in http://dartbug.com/30491 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f539785e038351d94973ec5aa8b9b546e63287b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M pkg/front_end/lib/src/incremental/file_state.dart View 5 chunks +12 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/incremental/kernel_driver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/src/incremental/file_state_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Siggi Cherem (dart-lang)
only need a review from one of you.
3 years, 3 months ago (2017-08-23 23:23:33 UTC) #4
scheglov
LGTM
3 years, 3 months ago (2017-08-24 00:25:30 UTC) #7
Siggi Cherem (dart-lang)
3 years, 3 months ago (2017-08-24 03:11:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
f539785e038351d94973ec5aa8b9b546e63287b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698