Remove most of the remaining references to AnalysisContext

Remove most of the remaining references to AnalysisContext

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e8b617217fb13d0302c20662212e608c634ee69c

[Brian Wilkerson, 2017-08-23 19:08:09]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-08-23 19:08:10]

There is one reference in CorrectionUtils that will take more work than I wanted
to do in this CL, and a few references in test code.

[scheglov, 2017-08-23 19:27:28]

lgtm

https://codereview.chromium.org/3007493002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
(right):

https://codereview.chromium.org/3007493002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/refactoring/rename_import.dart:123: (await
astProvider.driver.currentSession.getParsedAst(source.fullName))
Ideally I would prefer to put each `await` into a separate statement.
Especially in long statements.

Also here I'd extract `currentSession` into a local variable.

[Brian Wilkerson, 2017-08-23 19:56:52]

https://codereview.chromium.org/3007493002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
(right):

https://codereview.chromium.org/3007493002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/refactoring/rename_import.dart:123: (await
astProvider.driver.currentSession.getParsedAst(source.fullName))
Done

[Brian Wilkerson, 2017-08-23 19:57:13]

Description was changed from

==========
Remove most of the remaining references to AnalysisContext
==========

to

==========
Remove most of the remaining references to AnalysisContext

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e8b617217fb13d0302c20662212e608c634ee69c
==========

[Brian Wilkerson, 2017-08-23 19:57:14]

Committed patchset #1 (id:1) manually as
e8b617217fb13d0302c20662212e608c634ee69c (presubmit successful).