Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 300743002: Sync binding test results. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Sync binding test results. r174804 didn't update binding tests to account for [WillBeGarbageCollected]Node changes. R=nbarth@chromium.org,haraken@chromium.org BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -33 lines) Patch
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 3 chunks +7 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 3 chunks +7 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 3 chunks +7 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 4 chunks +5 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look.
6 years, 7 months ago (2014-05-27 07:37:51 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-27 07:42:37 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-27 07:43:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/300743002/1
6 years, 7 months ago (2014-05-27 07:43:31 UTC) #4
yhirano
Thanks for doing this!
6 years, 7 months ago (2014-05-27 07:44:01 UTC) #5
commit-bot: I haz the power
Change committed as 174844
6 years, 7 months ago (2014-05-27 07:44:19 UTC) #6
Nils Barth (inactive)
6 years, 7 months ago (2014-05-27 07:46:57 UTC) #7
Message was sent while issue was closed.
On 2014/05/27 07:44:01, yhirano wrote:
> Thanks for doing this!

Thanks sof!

Powered by Google App Engine
This is Rietveld 408576698