Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 300713002: Move NumberOfProcessorsOnline from CPU to OS (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Move NumberOfProcessorsOnline from CPU to OS It's really more an OS-level information, and this way the default platform doesn't depend on CPU-level details BUG=none R=yangguo@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M src/cpu.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/cpu.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/libplatform/default-platform.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/platform.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-cpu.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-26 15:12:26 UTC) #1
Yang
On 2014/05/26 15:12:26, jochen wrote: lgtm.
6 years, 7 months ago (2014-05-26 15:14:45 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-26 15:18:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698