[kernel] const constructor type arguments

[kernel] const constructor type arguments

```
class A<T> {
  const A();
  Type get type => T;
}

class B extends A<String>{
  const B();
}

main() {
  print(const B().type);
}
```

Should print "String".
Before this CL it printed "dynamic", now it prints "String".

See dartbug.com/30588 for more information.

BUG=
R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/e1d7e33aadf470164c7ceecba40a8a8d455cb459

[jensj, 2017-09-04 07:56:42]

jensj@google.com changed reviewers:
+ aam@google.com, ahe@google.com, kustermann@google.com

[jensj, 2017-09-04 07:56:43]

Note that I have not run the flutter code that the bug was created based on (I
don't know how to do that) --- but that the provided reproduction code seems to
work now.

Martin: Please check that I haven't done anything in the constant evaluator that
I'm not allowed to. I'm not quite sure if there's special rules about that.

https://codereview.chromium.org/3007123002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/3007123002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:2537: if (klass.NumTypeArguments() > 0 &&
!klass.IsGeneric()) {
This code is basically just a copy-pasta from the non-const case in
StreamingFlowGraphBuilder::BuildConstructorInvocation.

[kustermann, 2017-09-04 10:21:34]

lgtm

https://codereview.chromium.org/3007123002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/3007123002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:2537: if (klass.NumTypeArguments() > 0 &&
!klass.IsGeneric()) {
On 2017/09/04 07:56:42, jensj wrote:
> This code is basically just a copy-pasta from the non-const case in
> StreamingFlowGraphBuilder::BuildConstructorInvocation.

It seems correct, since NumTypeArguments (as opposed to NumTypeParameters)
returns the length of the type argument vector for an instance of [klass].

[jensj, 2017-09-04 11:24:33]

Description was changed from

==========
[kernel] const constructor type arguments

```
class A<T> {
  const A();
  Type get type => T;
}

class B extends A<String>{
  const B();
}

main() {
  print(const B().type);
}
```

Should print "String".
Before this CL it printed "dynamic", now it prints "String".

See dartbug.com/30588 for more information.

BUG=
==========

to

==========
[kernel] const constructor type arguments

```
class A<T> {
  const A();
  Type get type => T;
}

class B extends A<String>{
  const B();
}

main() {
  print(const B().type);
}
```

Should print "String".
Before this CL it printed "dynamic", now it prints "String".

See dartbug.com/30588 for more information.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e1d7e33aadf470164c7ceecba40a8a8d455cb459
==========

[jensj, 2017-09-04 11:24:34]

Committed patchset #1 (id:1) manually as
e1d7e33aadf470164c7ceecba40a8a8d455cb459 (presubmit successful).