Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3007093003: Mark conditional_import tests as failing for dart2js. (Closed)

Created:
3 years, 3 months ago by floitsch
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark conditional_import tests as failing for dart2js. Committed: https://github.com/dart-lang/sdk/commit/198d81674738a1fa9430d75a2585c0fde3a1b405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/language/language_dart2js.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
floitsch
TBR.
3 years, 3 months ago (2017-09-04 10:20:02 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 198d81674738a1fa9430d75a2585c0fde3a1b405 (presubmit successful).
3 years, 3 months ago (2017-09-04 10:20:24 UTC) #4
Siggi Cherem (dart-lang)
where there any changes in this area recently? (or the tests?) I'm just curious how ...
3 years, 3 months ago (2017-09-05 18:23:07 UTC) #5
Siggi Cherem (dart-lang)
(lgtm of course)
3 years, 3 months ago (2017-09-05 18:23:22 UTC) #6
floitsch
3 years, 3 months ago (2017-09-05 19:03:37 UTC) #7
Message was sent while issue was closed. 
On 2017/09/05 18:23:07, Siggi Cherem (dart-lang) wrote:
> where there any changes in this area recently? (or the tests?)
> 
> I'm just curious how all the sudden this started failing.

I couldn't find any.

Powered by Google App Engine
This is Rietveld 408576698