Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 3007033002: report const class as a more specific error code (Closed)

Created:
3 years, 3 months ago by danrubel
Modified:
3 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -24 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 2 chunks +11 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
danrubel
3 years, 3 months ago (2017-09-01 17:10:03 UTC) #3
Brian Wilkerson
lgtm
3 years, 3 months ago (2017-09-01 17:36:50 UTC) #4
danrubel
3 years, 3 months ago (2017-09-02 12:46:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7733322d796f0c62728c4374c2583f4e8c7fc43e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698