Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 3007023002: rank_stacks tweaks (Closed)

Created:
3 years, 3 months ago by sra1
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

rank_stacks tweaks - Cluster stacks on printed prefix instead of entire stack. - Print records with a stack that is a prefix of another stack (this happens for d8 errors where there is no dart2js stack) R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/dbcc7835a76fd752b4a8b886cc877b0cda7ade77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M pkg/compiler/tool/status_files/rank_stacks.dart View 6 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
3 years, 3 months ago (2017-09-01 17:10:52 UTC) #4
Siggi Cherem (dart-lang)
lgtm
3 years, 3 months ago (2017-09-01 17:17:14 UTC) #5
sra1
3 years, 3 months ago (2017-09-01 17:26:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
dbcc7835a76fd752b4a8b886cc877b0cda7ade77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698